Skip to content

fix(powerbi): clear the explicit-any and unused-export ratchets on staging - #8578

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/powerbi-ratchet-violations
Oct 2, 2026
Merged

fix(powerbi): clear the explicit-any and unused-export ratchets on staging#8578
waleedlatif1 merged 1 commit into
stagingfrom
fix/powerbi-ratchet-violations

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Oct 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

  • feat(powerbi): add Power BI actions #8538 merged after the ratchets landed, but its checks ran on an older base, so staging now fails check:explicit-any (8 new ! in the Power BI tests) and check:unused-exports (7 exports used only in their own file). Every PR rebased onto staging inherits the failure.
  • Replace the non-null assertions with named guards; drop export from the file-local Power BI types and constants.
  • Inline the refresh-attempt output properties at their single use: generate-docs only resolves exported consts by name, so un-exporting that one would have dropped a documented field. Generated docs are byte-identical.

Type of Change

  • Bug fix

Testing

  • bun run lint, bun run type-check, bun run check:audits (58 audits, incl. docs:check), docs-manifest:check, Power BI tests (34)

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

🤖 Generated with Claude Code

@vercel

vercel Bot commented Oct 2, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 2, 2026 6:43pm UTC

Request Review

@waleedlatif1

waleedlatif1 commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

waleedlatif1 commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Oct 2, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 12 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Cleans up TypeScript lint violations in Power BI integration code.

The PR appears safe to merge; no new actionable issue or outstanding previous finding remains.

Summary

The PR clears Power BI test and unused-export ratchets by replacing non-null assertions with guards, making file-local declarations private, and inlining refresh-attempt output properties. It also reverts the earlier documentation-generator change and its generated documentation updates.

Reviews (2) · Last reviewed commit: "fix(powerbi): clear the explicit-any and..."

greptile-apps[bot]
greptile-apps Bot reviewed Oct 2, 2026
View reviewed changes
Comment thread apps/docs/content/docs/integrations/shopify.mdx Outdated
Comment thread apps/docs/content/docs/integrations/manageengine_sdp.mdx
Comment thread scripts/generate-docs.ts Outdated
@waleedlatif1
fix(powerbi): clear the explicit-any and unused-export ratchets on st…
6541da1 
…aging

- replace the non-null assertions in the Power BI tests with named guards
- drop export from Power BI types and constants used only in their own file
- inline the refresh-attempt output properties at their one use, so the docs generator (which only resolves exported consts) renders them without a dead export
@waleedlatif1
waleedlatif1 force-pushed the fix/powerbi-ratchet-violations branch from a410bfb to 6541da1 Compare October 2, 2026 18:43
@waleedlatif1

waleedlatif1 commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

waleedlatif1 commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Oct 2, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit dd24582 into staging Oct 2, 2026
33 of 34 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/powerbi-ratchet-violations branch October 2, 2026 18:56
@waleedlatif1 waleedlatif1 mentioned this pull request Oct 2, 2026
Merged

This branch was previously deployed

1 inactive deployment
Preview — 6541da1c Deployed Oct 2, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments
@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@waleedlatif1