Skip to content

fix(search): correct onboarding and live citations - #8542

Merged
icecrasher321 merged 2 commits into
stagingfrom
codex/search-retirement-release-fixes
Oct 1, 2026
Merged

fix(search): correct onboarding and live citations#8542
icecrasher321 merged 2 commits into
stagingfrom
codex/search-retirement-release-fixes

Conversation

@icecrasher321

@icecrasher321 icecrasher321 commented Oct 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

  • Complete onboarding for configured service-account sources without requiring a member account, and clear readiness when a source credential is disconnected.
  • Use provider/container links for live citations and omit unavailable links.
  • Remove the stale Search-source tool parameter and restore column-retirement audit annotations.

Type of Change

  • Bug fix

Testing

82 focused unit tests and 24 real-PostgreSQL integration tests passed, including pre-fix failure proofs for the repaired regressions. App and DB type-checks, lint, migration safety, catalog parity, docs manifest, block registry, and repository audits passed. JSON test reports were written to caller-selected paths; CI uploads integration reports on failure.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 1, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 1, 2026 9:37pm UTC

Request Review

@icecrasher321

icecrasher321 commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

@icecrasher321

icecrasher321 commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@icecrasher321 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Oct 1, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 14 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread apps/sim/lib/knowledge/__integration__/search-mcp-setup.integration.ts
cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Oct 1, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 14 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@icecrasher321
icecrasher321 force-pushed the codex/search-retirement-release-fixes branch from 3368333 to 09cab78 Compare October 1, 2026 21:22
@icecrasher321 icecrasher321 changed the title fix(search): preserve repairs and live source readiness fix(search): correct onboarding and live citations Oct 1, 2026
@greptile-apps

greptile-apps Bot commented Oct 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[High risk] Modifies search integration status schema and live citation handling.

The PR appears safe to merge; no new actionable issue was identified.

Summary

The PR updates Search onboarding to recognize configured service-account sources, uses live provider or container links for citations, removes a stale tool parameter, and restores database column-retirement annotations.

Reviews (3) · Last reviewed commit: "fix(search): clear onboarding readiness ..."

@icecrasher321

icecrasher321 commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

greptile-apps[bot]
greptile-apps Bot reviewed Oct 1, 2026
View reviewed changes
Comment thread apps/sim/lib/knowledge/application/search-integrations.ts
Comment thread apps/sim/lib/knowledge/application/search-integrations.ts
@icecrasher321

icecrasher321 commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@icecrasher321 I have started the AI code review. It will take a few minutes to complete.

@icecrasher321

icecrasher321 commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Oct 1, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 12 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1 waleedlatif1 mentioned this pull request Oct 1, 2026
Merged
@icecrasher321

icecrasher321 commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

@icecrasher321

icecrasher321 commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@icecrasher321 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Oct 1, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 12 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@icecrasher321
icecrasher321 merged commit 428a945 into staging Oct 1, 2026
32 of 33 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/search-retirement-release-fixes branch October 1, 2026 22:59

This branch was previously deployed

1 inactive deployment
Preview — 8d7f3175 Deployed Oct 1, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments
@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@icecrasher321