fix: preserve HTTP error subclasses when pickling - #163
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTTPError.__reduce__always reconstructs the baseHTTPErrorclass. Consequently, pickling aTooManyRequestsErrororServiceUnavailableErrorsucceeds but loses its type. Callers receiving an exception from a worker can no longer catch the original subclass to apply their retry policy.Reconstruct
type(self)with the existing four serialized fields. This follows up on #148 and retains its pickle support while preserving the exception class.The regression covers every built-in status-specific error and the generic fallback, using every pickle protocol available in Python 3.12. All 66 subclass/protocol combinations fail before the fix and pass afterward; all 12 client unit tests pass. Pycodestyle and Pyflakes pass on both changed files.
Full discovery runs 14 tests: 13 pass and the existing copyright-year test fails because LICENSE says 2023 while the current year is 2026. No license text was changed. The legacy Python versions in CI were not run locally.
Checklist
main, the current CI/default branch (developmentno longer exists).