refactor(config): flatten nested shared config layers - #533
Open
chenjiahan wants to merge 2 commits into
Open
chenjiahan wants to merge 2 commits into
chenjiahan wants to merge 2 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying rstack-cli with
|
| Latest commit: |
300968f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://510397fb.rstack-cli.pages.dev |
| Branch Preview URL: | https://chenjiahan-nested-config-lay.rstack-cli.pages.dev |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Continue the unified configuration RFC by expanding nested shared configurations into ordered layers.
Changes
Add an internal depth-first traversal that visits inherited configs before their children and preserves sibling order. Reuse config normalization without executing tool factories or modifying inputs.
Preserve repeated references at every occurrence, while rejecting cycles on the active traversal path with both reference positions in the error. Public registration and loader integration will follow separately.