Skip to content

PEP 818: Add How to Teach & Change History, minor edits, new discuss post - #5156

Merged
StanFromIreland merged 4 commits into
python:mainfrom
hoodmane:818-how-to-teach-and-change-history
Oct 1, 2026
Merged

PEP 818: Add How to Teach & Change History, minor edits, new discuss post#5156
StanFromIreland merged 4 commits into
python:mainfrom
hoodmane:818-how-to-teach-and-change-history

Conversation

@hoodmane

@hoodmane hoodmane commented Oct 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Change is either:
    • To a Draft PEP
    • To an Accepted or Final PEP, with Steering Council approval
    • To fix an editorial issue (markup, typo, link, header, etc)
  • PR title prefixed with PEP number

@hoodmane
hoodmane requested a review from ambv as a code owner October 1, 2026 16:32
@read-the-docs-community

read-the-docs-community Bot commented Oct 1, 2026 •
edited
Loading

Copy link
Copy Markdown

Documentation build overview

📚 pep-previews | 🛠️ Build #34884691 | 📁 Comparing 5c2e420 against latest (bfec85f)

  🔍 Preview build  

1 file changed
± pep-0818/index.html

StanFromIreland
StanFromIreland reviewed Oct 1, 2026
View reviewed changes
Comment thread peps/pep-0818.rst
Comment thread peps/pep-0818.rst Outdated
StanFromIreland
StanFromIreland reviewed Oct 1, 2026
View reviewed changes
Comment thread peps/pep-0818.rst Outdated
@hoodmane

hoodmane commented Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the edits @StanFromIreland. Would appreciate it if you could merge it if it looks okay to you.

StanFromIreland
StanFromIreland approved these changes Oct 1, 2026
View reviewed changes

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit.

Comment thread peps/pep-0818.rst Outdated
StanFromIreland
StanFromIreland reviewed Oct 1, 2026
View reviewed changes
Comment thread peps/pep-0818.rst Outdated
@hoodmane

hoodmane commented Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

Okay fixed those two too.

StanFromIreland
StanFromIreland reviewed Oct 1, 2026
View reviewed changes
Comment thread peps/pep-0818.rst Outdated
hugovk
hugovk approved these changes Oct 1, 2026
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks both!

@StanFromIreland
StanFromIreland merged commit e449c7e into python:main Oct 1, 2026
5 checks passed
@hoodmane
hoodmane deleted the 818-how-to-teach-and-change-history branch October 1, 2026 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIreland StanFromIreland StanFromIreland approved these changes
@hugovk hugovk hugovk approved these changes
@ambv ambv Awaiting requested review from ambv ambv is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hoodmane @hugovk @StanFromIreland