Reject stale refinements after short-circuit RHS writes - #324
Draft
CatarinaGamboa wants to merge 1 commit into
Draft
CatarinaGamboa wants to merge 1 commit into
CatarinaGamboa wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The verifier scanned the right operand of
&&and||as though it always ran. A write there could then be trusted after Java had skipped it. After checking the operator, this change gives each variable written in its right operand a fresh unconstrained value, so a refinement cannot rely on the skipped assignment.This ports the paired reproducer and fix from closed #257 to current
main. The test uses the current// Expect:convention and adds||, nested assignments, increment, and a right operand without writes.Example
On
mainatdd02e996, the verifier accepts the expanded test file. This branch reports four expected refinement errors; the no-write case still passes. The original example fails its Java assertion when run with-ea.This is conservative: it forgets a RHS write even when the left operand happens to force the RHS to run, so some safe code may need a more precise future path merge to verify.
Related Issue
Fixes #323. Based on
5d3f1c29andc23f819dfrom #257; Guilherme Espada is credited in the commit.Type of change
Checklist
liquidjava-example/src/main/java/testSuite/mvn testpasses locally