fix(bind): handle maps with defined string key and value types - #3150
Open
sergioperezcheco wants to merge 1 commit into
Open
sergioperezcheco wants to merge 1 commit into
sergioperezcheco wants to merge 1 commit into
Conversation
Prepared with Hermes Agent (gpt-6.1-sol). Signed-off-by: sergioperezcheco <checo520@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The map binder checks string kinds, but then assigns plain string keys and values without converting them to the destination types. Normal requests therefore panic when binding to maps with a defined string key or value type. Convert those two values before assignment, preserving the existing first-value behavior for string and interface destinations and all-values behavior for slice destinations.
The regression exercises Context.Bind and explicit query, path, header, URL-encoded form and multipart binding through Echo.ServeHTTP, including nil map allocation and ordinary map controls. The unchanged implementation fails 24 of the 48 cases; the fix passes the full local race suite and go vet, with no incremental govet/staticcheck findings. CI's standalone golint/staticcheck, other Go versions and other operating systems have not been run locally.
Prepared with Hermes Agent; no human review is claimed.