Skip to content

chore(apple): give Swift Package Manager its own Firebase SDK pin - #18739

Draft
SelaseKay wants to merge 1 commit into
mainfrom
chore/split-ios-sdk-pins
Draft

SelaseKay wants to merge 1 commit into
mainfrom
chore/split-ios-sdk-pins

Conversation

@SelaseKay

Copy link
Copy Markdown
Contributor

Description

Splits the Firebase Apple SDK pin so Swift Package Manager no longer reads firebase_sdk_version.rb.

Both dependency managers currently share that Ruby pin, and scripts/generate_versions_spm.dart copies it into every Package.swift. Firebase stops publishing new Apple SDK versions to CocoaPods in October 2026, so the next bump of that file would break pod install.

scripts/firebase_sdk_version_spm.dart is the Swift Package Manager pin. It lives in scripts/, outside every plugin directory, so it is not part of a pub release. The generator writes the value into Package.swift before publish. Podspecs keep using packages/firebase_core/firebase_core/ios/firebase_sdk_version.rb, including the $FirebaseSDKVersion Podfile override. Both pins stay at 12.19.0.

The next bill of materials records ios from the CocoaPods pin and ios_spm from the Swift Package Manager pin. This pull request does not regenerate the current bill of materials.

Related Issues

None.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Test plan

  • dart analyze on scripts/firebase_sdk_version_spm.dart, scripts/generate_versions_spm.dart, and scripts/generate_bom.dart (only pre-existing unnecessary_raw_strings infos in the generator)
  • dart run scripts/generate_versions_spm.dart leaves every Package.swift on 12.19.0
  • CI Validate Generated SPM Versions passes

New firebase-ios-sdk releases stop publishing to CocoaPods in October 2026, so Package.swift can no longer share the podspec pin.
@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 馃憤 and 馃憥 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant