Conversation
run-workers split every loaded test across workers and let each worker apply --grep afterwards. A narrow pattern could put all matching tests on one worker while the others started only to report an empty run. Tests are now filtered by grep (and --invert, config grep, .only) before they are assigned, and workers that would get no tests are not started. When nothing matches, distribution is unchanged so workers still print the empty-run hint. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
run-workerssplits all loaded tests across workers and each worker applies--grepafterwards. With a narrow pattern the matching tests can land on one worker, while the others start only to print "No tests found by pattern".On the sandbox fixture (7 tests, 2 match):
Change
createGroupsOfTests/createGroupsOfSuitesassign only tests matching mocha's grep. That covers--grep,--invert, thegrepconfig key andFeature.only/Scenario.only.After:
Not changed
--by poolhands out files, not tests, so it still loads files that have no matching test.createGroupsOfTests(n)to custom scripts keep lengthn; only the built-in split drops empty ones.Tests
test/runner/run_workers_test.jsandtest/unit/worker_test.jspass locally (45 passing, 2 pending).🤖 Generated with Claude Code