feat: Add direct signal-to-noise over-sampling helper - #606
Merged
Merged
Conversation
Collaborator
Author
|
Companion documentation PR: PyAutoLabs/PyAutoGalaxy#644. Both belong to issue #602. |
This was referenced Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a helper that thresholds an existing signal-to-noise map directly, avoiding accidental division by noise a second time. The cutoff stays fixed even when the map has low S/N. Preserve the input mask and pixel metadata.
Part of #602. The companion PyAutoGalaxy PR corrects the adapt-image documentation; existing workspace thresholding remains compatible.
API Changes
Adds
aa.util.over_sample.over_sample_size_via_snr_from, also exposed throughal.util.over_sample. The existing adaptive helper keeps its behavior. See full details below.Test Plan
Full API Changes (for automation & release notes)
Added
over_sample_size_via_snr_from(signal_to_noise_map, signal_to_noise_cut=3.0, sub_size_lower=2, sub_size_upper=4)returns anArray2Dof integer sub-sizes, using a strict greater-than cutoff without noise division or cutoff lowering.Migration
over_sample_size_via_adapt_from.Generated by the PyAutoLabs agent workflow.