ignorePrAuthor is not being honored when included in parent config

[joeyweisband]

How are you running Renovate?

Self-hosted Renovate

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

GitLab; Renovate v39.69.3

Please tell us more about your question or problem

We want to globally set the ignorePrAuthor setting to "true". We tried this by setting the value in our parent config with a preset:

{
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"description": "Set ignorePrAuthor to allow queries to all MRs regardless of author",
"ignorePrAuthor": true
}

This did not produce the desired effect as Renovate was unable to find MRs from other owners.

We then tried setting the environment variable RENOVATE_IGNORE_PR_AUTHOR to true, and this worked.

We would prefer to set this value using config rather than an env. Why is this behavior occurring?

The following items are true:

• There are no default or custom presets that we know of that are overriding the ignorePrAuthor setting
• When the printConfig setting is turned on, the resolved global config is exactly the same when the preset is used vs. the ENV (no diff between the two)
• We noticed that the ignorePrAuthor setting is set to false on the resolved repository level config when the preset is used and true when the ENV is used.

Logs (if relevant)

Logs

See attached files for logs.

debugWithEnv.log
debugWithPreset.log

[github-actions[bot]]

Hi there,

This issue or discussion is missing some logs, making it difficult or impossible to help you. Depending on which situation applies follow one, some or all of these instructions.

No logs at all

If you haven't posted any log yet, we need you to find and copy/paste the log into the issue template.

Finding logs on hosted app

Select me to read instructions

If you use the Mend Renovate app (GitHub):

1. Log in to the Mend Developer Portal
2. Navigate to the correct organization and repository
3. Locate the appropriate log (it may not always be the latest one)
4. Copy/paste the log contents
5. Follow the steps in the formatting your logs section

Finding logs when self-hosting

Select me to read instructions

Read the Renovate docs, troubleshooting, self-hosted to learn how to find the logs.

Insufficient logs

Select me to read instructions

If you already gave us a log, and the Renovate team said it's not enough, then follow the instructions from the No logs at all section.

Formatting your logs

Select me to read instructions

Please put your logs in a <details> and <summary> element like this:

<details><summary>Select me to see logs</summary>

```
Copy/paste your logs here, between the starting and ending backticks
```

</details>

If you feel the logs are too large to paste here, please use a service like GitHub Gist and paste the link here.

Good luck,

The Renovate team

[a1flecke]

I am very curious about this as well

[rarkins]

Please describe what the importance/difference is between the two log files which were uploaded

[joeyweisband]

@rarkins

Apologies, we saw the behavior in the TRACE logs, but the files were too big to include the full log. I've taken the snippits that I think contain the behavior and included them here:

traceOutputSampleWithEnv.log - The trace logs of running renovate with the ENV explicitly set showing ignorePrAuthor set to true in the repo config. (Line 396125)

traceOutputSampleWithOnlyPreset.log - The trace logs of running renovate with only the preset showing ignorePrAuthor set to false in the repo config. (Line 396098)

[joeyweisband]

Hi @rarkins - just checking in on this. Did I provide all the necessary logs?

[rarkins]

Possibly yes, but unfortunately I don't have time to comb through such logs yet. However I do notice something confusing in your latest post - why is one showing true and another showing false? I thought you were intending to demonstrate two ways to set it to true

[joeyweisband]

@rarkins

I wanted to see if I could replicate the behavior by running Renovate locally.

• I ran renovate with the following preset:

{
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"description": "Set ignorePrAuthor to allow queries to all MRs regardless of author",
"ignorePrAuthor": true
}

• I set breakpoints in the following files and line numbers and observed this behavior:

  • lib/workers/repository/init/config.ts : Line 15 & 16

    • We see the preset be found and merged into the final resolved config

  • lib/workers/repository/init/index.ts : Line 78

    • We see the fully resolved config returned and the ignorePrAuthor field set to true

  • lib/workers/repository/dependency-dashboard.ts : Line 141

    • We see the issue being queried with the merged config with ignorePrAuthor set to true

  • lib/modules/platform/gitlab/index.ts : Line 1106

    • We see issues being queried for the repository where the ignorePrAuthor field is set to false

This causes renovate to not query for all issues, but only for issues created by the current renovate user.

[joeyweisband]

@rarkins - just checking in. Was this breakdown helpful?

[github-actions[bot]]

Hi there,

Get your discussion fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible.

Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this. Discussions without reproductions are less likely to be converted to Issues.

Please follow these steps:

1. Read our guide on creating a minimal reproduction.
2. Go to our minimal reproduction template repository.
3. Select the Use this template button to create a new repository based on the template.
4. Work on the minimal reproduction in your own repository.
5. Fill out the information in your repository's README.md.
6. Add the link to your reproduction to the first post of your Discussion. If you are not the original author, you can post a new comment with the link.

If you need help with running renovate on your minimal reproduction repository, please refer to our Running Renovate guide.
Good luck,

The Renovate team

[psychobolt]

I had the same issue. I tried setting ignorePrAuthor in renovate.json however, it isn't honored unless its set in the env config. As op mentioned using RENOVATE_IGNORE_PR_AUTHOR workaround. Actually, in my case since we were migrating bot accounts, it would be ideal to be configured per environment and switched off when migration is completed. So I think RENOVATE_IGNORE_PR_AUTHOR would be ideal over ignorePrAuthor

[trueberryless]

I think this is expected behaviour as you describe, because the ignorePrAuthor config is not meant for the renovate.json config, but rather the config.js for self-hosted runners. I was also confused by this, but all the options on that docs page are meant for admin configs (not repo configs) as you can see here:

[wlt-schaefer]

Adding ignorePrAuthor: true to .renovate/config.json causes the schema to become invalid:

[jamietanna]

Yes, ignorePrAuthor is only allowed for global self hosted configuration

[jamietanna]

I'm going to close + lock this - we shouldn't be nudging old threads, where possible