A legitimate upstream bug

[Aaren08]

the null guard missing at activity/index.mjs:140 is a legitimate upstream bug that needs:

javascript// What the source needs
case "PushEvent": {
let {size, commits, ref} = payload
if (!commits) // ← this one line fixes the entire crash
return null
commits = commits.filter(...)

And for habits:
javascript.flatMap(({payload}) => payload.commits ?? []) // ← nullish coalescing fixes it
.filter(({author}) => ...)

[sueun-dev]

yeah, this checks out and it looks like the same family as #1759/#1826.

I tried a tiny local fixture against current master (366f8b9) by importing source/plugins/activity/index.mjs directly, with a fake PushEvent where payload has size/ref but no commits. It throws exactly TypeError: Cannot read properties of undefined (reading 'filter') in the current push branch.

The source still does let {size, commits, ref} = payload and immediately calls commits.filter(...), so if (!commits) return null or commits = (commits ?? []).filter(...) is the right shape for activity. I only source-checked the habits line, but it has the same payload.commits ?? [] fix shape.